Fix IOSStorageFolder permission problem #13976
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dotnet-policy-service agree |
|
You can test this PR using the following package version. |
maxkatz6
reviewed
Dec 17, 2023
This commit fixes "Operation not permitted" errors when accessing folders opened via StorageProvider.OpenFolderPickerAsync by calling [Start/Stop]AccessingSecurityScopedResource on IOSStorageFolder's Url.
sghctoma
force-pushed
the
ios-folder-permission
branch
from
c87fa1f
to
6752255
Compare
Wrap individual operations in [Start/Stop]AccessingSecurityScopedResource calls instead of retaining access for the whole lifetime of the folder.
|
You can test this PR using the following package version. |
maxkatz6
added
the
backport-candidate-11.0.x
sghctoma
added a commit
to sghctoma/Sufni.Bridge
that referenced
this pull request
Dec 22, 2023
This contains the IOSStorageFolder permission fixes: AvaloniaUI/Avalonia#13976
maxkatz6
added
backported-11.0.x
and removed
backport-candidate-11.0.x
maxkatz6
pushed a commit
that referenced
this pull request
Jan 17, 2024
* Fix IOSStorageFolder permission problem This commit fixes "Operation not permitted" errors when accessing folders opened via StorageProvider.OpenFolderPickerAsync by calling [Start/Stop]AccessingSecurityScopedResource on IOSStorageFolder's Url. * Narrow down security scoped resource access scope Wrap individual operations in [Start/Stop]AccessingSecurityScopedResource calls instead of retaining access for the whole lifetime of the folder. #Conflicts: # src/iOS/Avalonia.iOS/Storage/IOSStorageItem.cs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
This PR aims to fix
StorageProvider.OpenFolderPickerAsyncpermission errors when run on an iOS device.What is the current behavior?
Folders opened using
StorageProvider.OpenFolderPickerAsynccan't be used on an iPhone, because of "Operation not permitted" errors on every operation.Please note that these errors occur only on a real device, the emulator works without the changes in this PR. My test device runs iOS 17.1.2, and I do not have access to any other Apple devices / iOS versions to test on.
I have attached a minimal test application to demonstrate this behavior. The application asks the user for a folder, and puts the name of all files and folders under it into a
ListBox. The file/folder list will appear in theListBoxwhen run in the emulator, but not when run on a real device.What is the updated/expected behavior with this PR?
With the commit in this PR, folders opened using
StorageProvider.OpenFolderPickerAsynccan be accessed as normal.How was the solution implemented (if it's not obvious)?
The root cause of the problem is that
IOSStorageFolderdoes not callStartAccessingSecurityScopedResource/StopAccessingSecurityScopedResourceon itsUrl. This PR adds these calls toIOSStorageFolder's constructor andDisposemethods, similarly toIOSSecurityScopedStream.