Remove missing MVID warning on XAML compilation #14014
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can test this PR using the following package version. |
kekekeks
approved these changes
Dec 22, 2023
maxkatz6
added
the
backport-candidate-11.0.x
maxkatz6
added
backported-11.0.x
and removed
backport-candidate-11.0.x
maxkatz6
pushed a commit
that referenced
this pull request
Jan 17, 2024
#Conflicts: # packages/Avalonia/AvaloniaBuildTasks.targets
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
This PR removes the annoying "Could not extract the MVID from "obj\path\refint\assembly.dll". Are you sure it is a reference assembly?" warning affecting builds using the XAML compiler.
While completely harmless, people often think it's a build failure, and the warning can't be easily removed.
How was the solution implemented (if it's not obvious)?
As commented in the modified .targets file:
Deletes the target ref assembly before the
CopyRefAssemblytask (in targetCopyFilesToOutputDirectory) tries to access it.CopyRefAssemblyreads the ref assembly's MVID from the.mvidPE section to avoid copying if necessary.However, Cecil doesn't preserve that PE section: this results in a warning.
By deleting the file beforehand, we're preventing the warning.
There are no changes in behavior since
CopyRefAssemblyalways copy the file if it couldn't read the MVID.References:
CopyRefAssemblysourceCopyRefAssemblycallFixed issues