Allow binding container IsVisible with virtualization. #14276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use `SetCurrentValue` to update the container `IsVisible` state when realizing and recycling so that the visible state can be bound. Fixes #13991
|
You can test this PR using the following package version. |
maxkatz6
approved these changes
Jan 19, 2024
maxkatz6
added
the
backport-candidate-11.0.x
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 19, 2024
Use `SetCurrentValue` to update the container `IsVisible` state when realizing and recycling so that the visible state can be bound. Fixes #13991
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
maxkatz6
deleted the
fixes/13991-recycling-items-with-isvisible-bindings
branch
maxkatz6
pushed a commit
that referenced
this pull request
Feb 8, 2024
Use `SetCurrentValue` to update the container `IsVisible` state when realizing and recycling so that the visible state can be bound. Fixes #13991
maxkatz6
added
backported-11.0.x
and removed
backport-candidate-11.0.x
|
Edit: it's probably related to other change since December. I will create an issue once I am able to reproduce it outside my app. I checked using latest master, trying to investigate it, but if you have an idea what may cause this please lmk |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
Allow binding the
IsVisibleproperty on containers in a virtualizedItemsControl.Use
SetCurrentValueto update the containerIsVisiblestate when realizing and recycling so that the visible state can be bound.Fixed issues
Fixes #13991