Use popupParent as X11 parent window #14366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the popupParent was ignored when present causing popups to have the X root window as its parent. This cause issues on gamescope (SteamOS session compositor) where that window would end up behind the main window. Signed-off-by: Mary Guillemard <[email protected]>
|
@dotnet-policy-service agree |
kekekeks
approved these changes
Jan 29, 2024
|
You can test this PR using the following package version. |
maxkatz6
added
the
backport-candidate-11.0.x
maxkatz6
added a commit
that referenced
this pull request
Feb 8, 2024
Previously, the popupParent was ignored when present causing popups to have the X root window as its parent. This cause issues on gamescope (SteamOS session compositor) where that window would end up behind the main window. Signed-off-by: Mary Guillemard <[email protected]> Co-authored-by: Max Katz <[email protected]>
maxkatz6
added
backported-11.0.x
and removed
backport-candidate-11.0.x
|
Hmmm, it seems that we should have used WM_TRANSIENT_FOR instead of parent/child relationships |
kekekeks
added a commit
that referenced
this pull request
Feb 10, 2024
kekekeks
added a commit
that referenced
this pull request
Feb 10, 2024
maxkatz6
pushed a commit
that referenced
this pull request
Feb 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the popupParent was ignored when present causing popups to have the X root window as its parent.
This cause issues on gamescope (SteamOS session compositor) where that window would end up behind the main window.
Currently blocker for Ryujinx new UI to be deployed in production.