Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix IActivatableApplicationLifetime definition #14400

Merged
merged 3 commits into from
Feb 1, 2024
Merged

Fix IActivatableApplicationLifetime definition #14400

merged 3 commits into from
Feb 1, 2024

Conversation

maxkatz6
Copy link
Member

This interface is not client implementable, also should inherit IApplicationLifetime as it's a lifetime

@maxkatz6 maxkatz6 added the backport-candidate-11.0.x Consider this PR for backporting to 11.0 branch label Jan 30, 2024
@avaloniaui-bot
Copy link

You can test this PR using the following package version. 11.1.999-cibuild0044152-beta. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

@maxkatz6 maxkatz6 added this pull request to the merge queue Jan 30, 2024
kekekeks
kekekeks reviewed Jan 30, 2024
View reviewed changes
Copy link
Member

@kekekeks kekekeks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should inherit IApplicationLifetime as it's a lifetime

I'd prefer to move to IOptionalFeatureProvider since the feature is optional and IDynamicInterfaceCastable isn't available for netfx.

@maxkatz6 maxkatz6 removed this pull request from the merge queue due to a manual request Jan 30, 2024
@avaloniaui-bot
Copy link

You can test this PR using the following package version. 11.1.999-cibuild0044222-beta. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

@maxkatz6
Copy link
Member Author

maxkatz6 commented Feb 1, 2024

I'd prefer to move to IOptionalFeatureProvider since the feature is optional and IDynamicInterfaceCastable isn't available for netfx.

Reverted "inherit IApplicationLifetime" part for now. Merging as is, with a plan to rewrite lifetimes/app features in the future. Stuff like global "IStorageProvider" can also be integrated there as well.

@maxkatz6 maxkatz6 added this pull request to the merge queue Feb 1, 2024
Merged via the queue into master with commit 1402369 Feb 1, 2024
7 checks passed
@maxkatz6 maxkatz6 deleted the maxkatz6-patch-4 branch February 1, 2024 03:45
maxkatz6 added a commit that referenced this pull request Feb 8, 2024
@maxkatz6
Fix IActivatableApplicationLifetime definition (#14400)
d3eb827 
* Fix IActivatableApplicationLifetime definition

* Remove ": IApplicationLifetime" for now, as API is going to change in future
@maxkatz6 maxkatz6 added backported-11.0.x and removed backport-candidate-11.0.x Consider this PR for backporting to 11.0 branch labels Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kekekeks kekekeks kekekeks left review comments

@danwalmsley danwalmsley danwalmsley approved these changes

Assignees
No one assigned
Labels
backported-11.0.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@maxkatz6 @avaloniaui-bot @kekekeks @danwalmsley