Fix controls not showing up in accessibility when made visibile #14424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was already a test for when visibility moves from visible to invisible but we were missing one for the other way around.
When an invisible control is encountered, unless a peer is created for it, there is nothing to listen for the `IsVisible` property changing to `true`. Make sure we create a peer even for invisible controls; we just don't add them to the child collection.
|
You can test this PR using the following package version. |
maxkatz6
approved these changes
Jan 31, 2024
maxkatz6
added
the
backport-candidate-11.0.x
grokys
added a commit
that referenced
this pull request
Feb 1, 2024
* Add failing test for control visibility changing. There was already a test for when visibility moves from visible to invisible but we were missing one for the other way around. * Create peer even for invisible controls. When an invisible control is encountered, unless a peer is created for it, there is nothing to listen for the `IsVisible` property changing to `true`. Make sure we create a peer even for invisible controls; we just don't add them to the child collection.
maxkatz6
pushed a commit
that referenced
this pull request
Feb 8, 2024
* Add failing test for control visibility changing. There was already a test for when visibility moves from visible to invisible but we were missing one for the other way around. * Create peer even for invisible controls. When an invisible control is encountered, unless a peer is created for it, there is nothing to listen for the `IsVisible` property changing to `true`. Make sure we create a peer even for invisible controls; we just don't add them to the child collection.
maxkatz6
added
backported-11.0.x
and removed
backport-candidate-11.0.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
When an invisible control is encountered, unless a peer is created for it, there is nothing to listen for the
IsVisibleproperty changing totrue. Make sure we create a peer even for invisible controls; we just don't add them to the child collection. The peer will then pick up the control being made visible and cause the parent to recalculate its children.