Avoid NRE from GetGlyphPath #14530
Merged
Avoid NRE from GetGlyphPath #14530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxkatz6
added
the
backport-candidate-11.0.x
|
You can test this PR using the following package version. |
Gillibald
approved these changes
Feb 8, 2024
|
You can test this PR using the following package version. |
maxkatz6
added a commit
that referenced
this pull request
Feb 9, 2024
Co-authored-by: Jumar Macato <[email protected]>
maxkatz6
added
backported-11.0.x
and removed
backport-candidate-11.0.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
While building glyph run geometry, GetGlyphPath can return null SKPath. I can consistently reproduce it on macOS in RenderDemo - FormattedText page.
Not sure if it's a correct fix, but seems like it, since we already ignore empty paths.