Add basic support for automation for DataGrid and DataGridRow #15174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can test this PR using the following package version. |
maxkatz6
reviewed
Mar 30, 2024
|
|
||
| protected override AutomationControlType GetAutomationControlTypeCore() | ||
| { | ||
| return AutomationControlType.Custom; |
There was a problem hiding this comment.
UWP implementation uses three state possible values here:
https://github.com/CommunityToolkit/WindowsCommunityToolkit/blob/main/Microsoft.Toolkit.Uwp.UI.Controls.DataGrid/DataGrid/Automation/DataGridCellAutomationPeer.cs#L82-L98
There was a problem hiding this comment.
But I guess it's not as necessary for starters, since basic text works either way.
maxkatz6
approved these changes
Mar 30, 2024
maxkatz6
added
the
backport-candidate-11.1.x
|
You can test this PR using the following package version. |
maxkatz6
pushed a commit
that referenced
this pull request
Apr 6, 2024
* Add basic support for automation for DataGrid and DataGridRow * Add DataGridCellAutomationPeer * Add DataGridColumnHeaderAutomationPeer * Add DataGridColumnHeadersPresenterAutomationPeer * Add DataGridDetailsPresenterAutomationPeer
maxkatz6
added
backported-11.1.x
and removed
backport-candidate-11.1.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
Adds basic automation support for DataGrid/DataGridRow
What is the current behavior?
DataGrid/DataGridRow controls are missing basic automation support.
What is the updated/expected behavior with this PR?
DataGrid/DataGridRow controls have basic automation support.
How was the solution implemented (if it's not obvious)?
Added automation peers for DataGrid/DataGridRow controls.
Checklist
Breaking changes
Obsoletions / Deprecations
Fixed issues
Part of #10143