-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Android] Support PerformContextMenuAction
#15608
[Android] Support PerformContextMenuAction
#15608
Conversation
You can test this PR using the following package version. |
@Gillibald @emmauss don't we have a better API in the IME for that? If not, it might make sense to add, instead of creating fake hotkey input. |
All this should go through the TextInputMethodClient so y we need to add some API for inserting and deleting |
So I should wait for the API changed? |
any updates? |
We need a common way of executing known context Manu action. Ideally an enum with known action names. TextInputMethodClient will then expose |
You can test this PR using the following package version. |
When will this be contained in the Release? (In the 11.1.0 rc) |
@Tangent-90 it will be in 11.1.1 release. |
It is 11.1.2 now, but this and #15603 still not be released. Including these will improve the input expression on Android devices. And I really need these features. |
* support PerformContextMenuAction * update * update to new api
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😎
What does the pull request do?
Support
PerformContextMenuAction
so that application can react on IME copy paste commandWhat is the current behavior?
App will not react when press copy/paste/cut/select all button on IME
Screenrecorder-2024-05-05-01-17-09-49.mp4
What is the updated/expected behavior with this PR?
App will react when press copy/paste/cut/select-all button on IME now
Screenrecorder-2024-05-05-01-20-50-906.mp4
How was the solution implemented (if it's not obvious)?
When press copy/paste/cut/select-all button, the Android IME will call
BaseInputConnection.performContextMenuAction(int id)
to make command workChecklist
Breaking changes
Obsoletions / Deprecations
Fixed issues