Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to normalize family names for embedded fonts #15703

Merged
merged 7 commits into from
May 24, 2024

Conversation

Gillibald
Copy link
Contributor

@Gillibald Gillibald commented May 13, 2024

  • Allow loading typefaces with a family name that includes known keywords like Bold, Black, etc.
  • Make sure we filter out null family names when we call SKFontManager.GetInstalledFontFamilyNames
  • Normalize family names specified via fontSource#FamilyName so known keywords are filtered out before caching them in the font collection.

What does the pull request do?

What is the current behavior?

What is the updated/expected behavior with this PR?

How was the solution implemented (if it's not obvious)?

Checklist

Breaking changes

Obsoletions / Deprecations

Fixed issues

@Gillibald Gillibald added backport-candidate-11.0.x Consider this PR for backporting to 11.0 branch backport-candidate-11.1.x Consider this PR for backporting to 11.1 branch labels May 13, 2024
@avaloniaui-bot
Copy link

You can test this PR using the following package version. 11.2.999-cibuild0048372-alpha. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

@cla-avalonia
Copy link
Collaborator

cla-avalonia commented May 13, 2024

  • All contributors have signed the CLA.

@Gillibald
Copy link
Contributor Author

@cla-avalonia agree

@Gillibald Gillibald changed the title Try to normalize family names for embedded fonts [WIP] Try to normalize family names for embedded fonts May 13, 2024
@Gillibald Gillibald changed the title [WIP] Try to normalize family names for embedded fonts Try to normalize family names for embedded fonts May 21, 2024
@avaloniaui-bot
Copy link

You can test this PR using the following package version. 11.2.999-cibuild0048566-alpha. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

@grokys grokys added this pull request to the merge queue May 24, 2024
Merged via the queue into AvaloniaUI:master with commit 1121879 May 24, 2024
10 checks passed
@maxkatz6 maxkatz6 added the bug label Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-candidate-11.0.x Consider this PR for backporting to 11.0 branch backport-candidate-11.1.x Consider this PR for backporting to 11.1 branch bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants