-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Try to normalize family names for embedded fonts #15703
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the requested family name
Gillibald
added
backport-candidate-11.0.x
Consider this PR for backporting to 11.0 branch
backport-candidate-11.1.x
Consider this PR for backporting to 11.1 branch
labels
May 13, 2024
You can test this PR using the following package version. |
|
@cla-avalonia agree |
Gillibald
changed the title
Try to normalize family names for embedded fonts
[WIP] Try to normalize family names for embedded fonts
May 13, 2024
Gillibald
changed the title
[WIP] Try to normalize family names for embedded fonts
Try to normalize family names for embedded fonts
May 21, 2024
maxkatz6
approved these changes
May 21, 2024
You can test this PR using the following package version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport-candidate-11.0.x
Consider this PR for backporting to 11.0 branch
backport-candidate-11.1.x
Consider this PR for backporting to 11.1 branch
bug
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bold, Black, etc.
SKFontManager.GetInstalledFontFamilyNames
fontSource#FamilyName
so known keywords are filtered out before caching them in the font collection.What does the pull request do?
What is the current behavior?
What is the updated/expected behavior with this PR?
How was the solution implemented (if it's not obvious)?
Checklist
Breaking changes
Obsoletions / Deprecations
Fixed issues