Fix some issues with strokeless geometry segments #16019
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For polyline segment with `IsStroked = false`.
If an empty (but non-null) stroke was passed to `CombinedGeometryImpl` then its empty bounds would be used and the fill bounds ignored. Added a test and fixed that.
|
You can test this PR using the following package version. |
grokys
added
bug
backport-candidate-11.1.x
kekekeks
approved these changes
Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
Support for strokeless geometry segments was added in #15430 but there were a couple of remaining issues with that:
PolyLineSegmentdid not respectIsStrokedGeometryImpl.GetRenderBoundsdid not correctly handle differing fill and strokeStreamGeometryImplhad some problems with non-stroked drawingCombinedGeometryImplreported an emptyBoundswhen stroke was empty, even if fill was presentThis PR fixes those issues.