Fix Linux X11 Atoms lost: Before the window was mapped, only the first atom was set. #16110
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
ShowInTaskBar="False"
,Topmost="True"
,WindowState = WindowState.FullScreen
.What is the current behavior?
For example, if we set window properties like this:
Before this PR, we can only find that the taskbar icon is hidden, but the window is not topmost and not full screen.
What is the updated/expected behavior with this PR?
After this PR, we can find that the taskbar icon is hidden, the window is topmost, and the window is full screen.
How was the solution implemented (if it's not obvious)?
See the code before this PR:
The newAtoms add only the header of the pointer
ptr
. So only the first atom was added even if thefor
runs multiple times.We changed the code to:
So all atoms are added to the newAtoms.
Checklist
Breaking changes
None.
The X11 atoms change is unique and the X system auto removes the repeated atoms so it is safe to add multiple atoms even if the developers add the same atoms themselves.
Obsoletions / Deprecations
None.
Fixed issues