Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix embedded TopLevel coordinate conversion #16181

Merged
merged 7 commits into from
Jul 4, 2024

Conversation

Gillibald
Copy link
Contributor

@Gillibald Gillibald commented Jul 1, 2024

What does the pull request do?

This PR makes sure mouse events processed by an embedded TopLevels have proper client and screen coordinate handling

What is the current behavior?

What is the updated/expected behavior with this PR?

How was the solution implemented (if it's not obvious)?

Checklist

Breaking changes

Obsoletions / Deprecations

Fixed issues

@Gillibald Gillibald added backport-candidate-11.1.x Consider this PR for backporting to 11.1 branch and removed backport-candidate-11.1.x Consider this PR for backporting to 11.1 branch labels Jul 1, 2024
@avaloniaui-bot
Copy link

You can test this PR using the following package version. 11.2.999-cibuild0049671-alpha. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

@avaloniaui-bot
Copy link

You can test this PR using the following package version. 11.2.999-cibuild0049764-alpha. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

native/Avalonia.Native/src/OSX/AvnView.mm Outdated Show resolved Hide resolved
@Gillibald Gillibald enabled auto-merge July 4, 2024 08:38
@avaloniaui-bot
Copy link

You can test this PR using the following package version. 11.2.999-cibuild0049814-alpha. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

@Gillibald Gillibald added this pull request to the merge queue Jul 4, 2024
Merged via the queue into AvaloniaUI:master with commit 3eda9a0 Jul 4, 2024
10 checks passed
@Gillibald Gillibald deleted the macEmbeddingCoords branch July 4, 2024 16:51
Gillibald added a commit to Gillibald/Avalonia that referenced this pull request Jul 29, 2024
* Fix embedded TopLevel coordinate conversion

* Adjust client / screen coordinate conversion

* Remove commented code
Gillibald added a commit that referenced this pull request Jul 30, 2024
* Fix embedded TopLevel coordinate conversion

* Adjust client / screen coordinate conversion

* Remove commented code
@maxkatz6 maxkatz6 added the bug label Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants