Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move IsDirect = true into DirectPropertyBase #16256

Merged
merged 3 commits into from
Jul 28, 2024
Merged

Move IsDirect = true into DirectPropertyBase #16256

merged 3 commits into from
Jul 28, 2024

Conversation

heku
Copy link
Contributor

@heku heku commented Jul 8, 2024

This line better to place in the base class DirectPropertyBase instead of DirectProperty<TOwner, TValue>.

IsDirect = true;

@avaloniaui-bot
Copy link

You can test this PR using the following package version. 11.2.999-cibuild0049923-alpha. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

@avaloniaui-bot
Copy link

You can test this PR using the following package version. 11.2.999-cibuild0049933-alpha. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

@heku heku force-pushed the move_IsDirect_setter_into_DirectPropertyBase branch from 861c715 to b693d86 Compare July 9, 2024 11:27
@avaloniaui-bot
Copy link

You can test this PR using the following package version. 11.2.999-cibuild0049954-alpha. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

@avaloniaui-bot
Copy link

You can test this PR using the following package version. 11.2.999-cibuild0049969-alpha. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

MrJul
MrJul approved these changes Jul 27, 2024
View reviewed changes
Copy link
Member

@MrJul MrJul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@MrJul MrJul enabled auto-merge July 27, 2024 13:33
@avaloniaui-bot
Copy link

You can test this PR using the following package version. 11.2.999-cibuild0050548-alpha. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

@MrJul MrJul added this pull request to the merge queue Jul 27, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 27, 2024
@MrJul MrJul added this pull request to the merge queue Jul 28, 2024
Merged via the queue into AvaloniaUI:master with commit 78935ba Jul 28, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MrJul MrJul MrJul approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@heku @avaloniaui-bot @MrJul @maxkatz6