-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Text] Fix infinite loop hang on selection of bidi text #16306
[Text] Fix infinite loop hang on selection of bidi text #16306
Conversation
Hi @Gillibald, check this out! |
|
@cla-avalonia agree |
You can test this PR using the following package version. |
What was happening here Will have a detailed look shortly |
I think the general issue that needs to be fixes is that the |
Just thrown first random fix I've found. Please use my unit test and provide your own well-thought fix. Thanks! |
You can test this PR using the following package version. |
…aytis/Avalonia into TextSelectionInfiniteLoopFreezeFix
You can test this PR using the following package version. |
You can test this PR using the following package version. |
You can test this PR using the following package version. |
What does the pull request do?
Fixed infinite loop hand when selecting specific bidi text with different text style parameters. Found by our QA.
What is the current behavior?
Infinite loop hang. I've added unit test - comment my 3-line fix and run it. it will run forever
What is the updated/expected behavior with this PR?
this case is handled