[WinRT] Added watchdog for ICompositor5::RequestCommitAsync #16393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kekekeks
added
backported-11.1.x
backport-candidate-11.1.x
|
You can test this PR using the following package version. |
maxkatz6
reviewed
Jul 22, 2024
| cbSize = Marshal.SizeOf<UnmanagedMethods.WNDCLASSEX>(), | ||
| hInstance = UnmanagedMethods.GetModuleHandle(null), | ||
| lpfnWndProc = s_wndProcDelegate, | ||
| lpszClassName = s_className = "AvaloniaSimpleWindow-" + Guid.NewGuid(), |
There was a problem hiding this comment.
Not really descriptive. Having different classnames for offscreen and winui-hack windows might help somebody's in the future.
There was a problem hiding this comment.
The window class is now reused for all windows to avoid wasting resources for no reason. It's not possible to customize it per-window anymore
maxkatz6
approved these changes
Jul 22, 2024
|
I don't have parallels locally, but I will run in on my windows at least for a sanity check today before merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that
windows::UI::Composition::ICompositor5.RequestCommitAsynccan get stuck if corresponding commit was submitted with rendering produced by a D3D11Device that will become lost afterwards (GetDeviceRemovedReason()still reports that everything is okie-dokie, but in reality the driver could have been reset a minute ago).The workaround checks if DWM hasn't triggered IAsyncAction completion event for a minute and triggers a next render loop tick regardless.