Win32.PlatformConstants uses buildNumber instead of version #16453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can test this PR using the following package version. |
|
|
@cla-avalonia agree |
maxkatz6
added
bug
os-windows
backport-candidate-11.1.x
maxkatz6
pushed a commit
that referenced
this pull request
Aug 12, 2024
maxkatz6
added
backported-11.1.x
and removed
backport-candidate-11.1.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
Changes the definition of
Avalonia.Win32.PlatformConstants.Windows10_1607to correctly create theVersionclass using Windows 10-1607 buildNumber (and not the marketing version).What is the current behavior?
This test
is always false for any windows 10 version since it's comparing windows internal build number (which starts at 10240 for the first Windows 10 version) to the marketing Version (1607).
What is the updated/expected behavior with this PR?
With this change, the previous test will correctly return false when ran on Windows 10 version 1507 (Codename Threshold, BuildNumber 10240) or on Windows 10 version 1511 (Codename Threshold2, BuildNumber 10586).
Fixed issues
Fixes #16444