fix: Button should not fire the click event on the space key when it is not active

[workgroupengineering]

What does the pull request do?

What is the current behavior?

What is the updated/expected behavior with this PR?

How was the solution implemented (if it's not obvious)?

Checklist

• Added unit tests (if possible)?
• Added XML documentation to any related classes?
• Consider submitting a PR to https://github.com/AvaloniaUI/avalonia-docs with user documentation

Breaking changes

Obsoletions / Deprecations

Fixed issues

Fixes #16184

[avaloniaui-bot]

You can test this PR using the following package version. 11.2.999-cibuild0051072-alpha. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

[workgroupengineering]

Hi @amwx , when you have time try this PR.

[avaloniaui-bot]

You can test this PR using the following package version. 11.2.999-cibuild0051097-alpha. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

[MrJul]

I'm a bit torn here. Child controls are supposed to mark events as handled to avoid special cases in parent controls. Here, doing so with KeyDown/KeyUp will prevent TextInput, so that's not a viable solution.

Since this PR solves a real problem, let's go with the focus check for now. I don't see any immediate issue with it, but that's the kind of change that might break unusual hierarchies. Let's be vigilant for future issues.

[avaloniaui-bot]

You can test this PR using the following package version. 11.2.999-cibuild0051165-alpha. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]