Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changed modifiers for injected non-client implementable method #16626

Merged
merged 2 commits into from
Aug 19, 2024
Merged

Changed modifiers for injected non-client implementable method #16626

merged 2 commits into from
Aug 19, 2024

Conversation

kekekeks
Copy link
Member

@kekekeks kekekeks commented Aug 8, 2024 •
edited
Loading

Apparently the current roslyn version no longer fails the build.

Checked with BuildToNuGetCache, test with CI packages before merging.

@kekekeks kekekeks added backport-candidate-11.0.x Consider this PR for backporting to 11.0 branch backport-candidate-11.1.x Consider this PR for backporting to 11.1 branch labels Aug 8, 2024
@kekekeks
Copy link
Member Author

kekekeks commented Aug 8, 2024 •
edited
Loading

#16623 #15736

@avaloniaui-bot
Copy link

You can test this PR using the following package version. 11.2.999-cibuild0051093-alpha. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

@maxkatz6 maxkatz6 added customer-priority Issue reported by a customer with a support agreement. area-infrastructure Issues related to CI/tooling infrastructur labels Aug 8, 2024
maxkatz6
maxkatz6 approved these changes Aug 19, 2024
View reviewed changes
Copy link
Member

@maxkatz6 maxkatz6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with IPen example, as well as tested existing project that uses PrivateAPI.
Everything works as expected.

@maxkatz6 maxkatz6 merged commit 135b598 into master Aug 19, 2024
12 checks passed
@maxkatz6 maxkatz6 deleted the fixes/fix-non-client-implementable branch August 19, 2024 21:44
grokys pushed a commit that referenced this pull request Oct 8, 2024
@kekekeks @grokys
Changed modifiers for injected non-client implementable method (#16626)
3d86730 
* Changed modifiers for injected non-client implementable method

* Keep internal modifier
@grokys grokys added backported-11.1.x and removed backport-candidate-11.1.x Consider this PR for backporting to 11.1 branch labels Oct 8, 2024
grokys pushed a commit that referenced this pull request Oct 8, 2024
@kekekeks @grokys
Changed modifiers for injected non-client implementable method (#16626)
78b0001 
* Changed modifiers for injected non-client implementable method

* Keep internal modifier
@grokys grokys added backported-11.0.x and removed backport-candidate-11.0.x Consider this PR for backporting to 11.0 branch labels Oct 8, 2024
@stevemonaco stevemonaco mentioned this pull request Oct 13, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxkatz6 maxkatz6 maxkatz6 approved these changes

Assignees

@maxkatz6 maxkatz6

Labels
area-infrastructure Issues related to CI/tooling infrastructur backported-11.0.x backported-11.1.x customer-priority Issue reported by a customer with a support agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kekekeks @avaloniaui-bot @maxkatz6 @grokys