-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix AutomationProperties.HelpText on macos #17046
Merged
Gillibald
merged 8 commits into
AvaloniaUI:master
from
ahopper:fix-automation-helptext-on-macos
Sep 24, 2024
Merged
Fix AutomationProperties.HelpText on macos #17046
Gillibald
merged 8 commits into
AvaloniaUI:master
from
ahopper:fix-automation-helptext-on-macos
Sep 24, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
You can test this PR using the following package version. |
|
@cla-avalonia agree |
maxkatz6
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
On macos AutomationProperties.HelpText is not made available to screen readers
What is the current behavior?
What is the updated/expected behavior with this PR?
if AutomationProperties.HelpText or a tooltip is set on a control the text will be read out by a screen reader on Macos
How was the solution implemented (if it's not obvious)?
This builds on #17030
Checklist
Breaking changes
Obsoletions / Deprecations
Fixed issues