Use coercion for MaskedTextBox.Text #17143
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
This PR uses coercion to change
MaskedTextBox.Text
wheneverText
is externally changed to a value that doesn't match the mask.What is the current behavior?
The
Text
property is immediately changed back inOnPropertyChanged
, causing reentrancy and property change events to be sent out of order. See #16746 (comment) for more context.What is the updated/expected behavior with this PR?
Extra property change events aren't raised.
The invalid value is invisible to external listeners.
How was the solution implemented?
The new implementation uses a coercion callback.
The coercion callback from
TextBox
has been exposed as avirtual CoerceText
method, since it's responsible for undo/redo. Without this, usingOverrideMetadata(TextProperty)
on anyTextBox
descendant breaks the undo/redo feature.Checklist