Don't apply our weird window positioning hacks for clicks on traffic lights #17181
+19
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lights This hack fixes the minimize problem with macOS 15.0
|
Not quite sure if we should still trigger that NonClientLeftButtonDown event. It seems to be used for cancelling drag and mouse-leave events too. |
|
You can test this PR using the following package version. |
maxkatz6
added
the
backport-candidate-11.2.x
This was referenced Oct 4, 2024
maxkatz6
added
backport-candidate-11.0.x
grokys
pushed a commit
that referenced
this pull request
Oct 4, 2024
…lights (#17181) This hack fixes the minimize problem with macOS 15.0
grokys
pushed a commit
that referenced
this pull request
Oct 8, 2024
…lights (#17181) This hack fixes the minimize problem with macOS 15.0
grokys
pushed a commit
that referenced
this pull request
Oct 8, 2024
…lights (#17181) This hack fixes the minimize problem with macOS 15.0
grokys
added
backported-11.0.x
backported-11.1.x
and removed
backport-candidate-11.0.x
maxkatz6
pushed a commit
that referenced
this pull request
Oct 27, 2024
…lights (#17181) This hack fixes the minimize problem with macOS 15.0
maxkatz6
added
backported-11.2.x
and removed
backport-candidate-11.2.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This hack fixes the minimize problem with macOS 15.0
In general we should reconsider our habit of calling BringToFront on every click since checking for hit-tested view can't be healthy.
Could also do an alternative check for the hit-test resulting somewhere in contentView hierarchy to avoid className comparisons.