Fix LayoutUpdated and EffectiveViewportChanged double registration #17196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrJul
added
bug
backport-candidate-11.2.x
|
You can test this PR using the following package version. |
maxkatz6
approved these changes
Oct 4, 2024
|
You can test this PR using the following package version. |
|
You can test this PR using the following package version. |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
maxkatz6
pushed a commit
that referenced
this pull request
Oct 27, 2024
…17196) * Add failing test for LayoutUpdated and EffectiveViewportChanged * Fix LayoutUpdated and EffectiveViewportChanged registration
maxkatz6
added
backported-11.2.x
and removed
backport-candidate-11.2.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
This PR ensures that
LayoutableeventsLayoutUpdatedandEffectiveViewportChangedaren't subscribed twice if they are registered inOnAttachedToVisualTree()or theAttachedToVisualTreeevent.Unit tests have been added.
What is the current behavior?
Subscribing to
LayoutUpdatedorEffectiveViewportChangedwhile insideOnAttachedToVisualTreeeffectively adds the handler twice to the underlyingLayoutManager.What is the updated/expected behavior with this PR?
The handler is added only once to
LayoutManager.