Implement TryGetFeature on secondary previewer windows #17409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxkatz6
added
bug
regression
area-previewer
backport-candidate-11.2.x
|
You can test this PR using the following package version. |
|
You can test this PR using the following package version. |
MrJul
approved these changes
Nov 3, 2024
maxkatz6
added a commit
that referenced
this pull request
Nov 14, 2024
maxkatz6
added
backported-11.2.x
and removed
backport-candidate-11.2.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
A corner case, but still a regression.
With previewer, we have two different IWindowImpl implementations: PreviewerWindowImpl and WindowStub.
Where first one is actually used to render previewer contents, and second is only used for secondary windows opened on side, not rendered anywhere.
In one of my previous Screen PRs I moved IScreenImpl initialization to the TryGetFeature method, but haven't noticed this second WindowStub implementation. Which regressed in #17401.
Note for future: consider removing all these stubs, and instead basing previewer protocol on top of Avalonia.Headless.
Fixed issues
Fixes #17401