CalendarDatePicker - use CustomDateFormatString for parsing the text input #17465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can test this PR using the following package version. |
punker76
force-pushed
the
fixes/17291-use-customdatastringformat-for-text-input
branch
from
97e3394
to
3ece70e
Compare
|
You can test this PR using the following package version. |
punker76
force-pushed
the
fixes/17291-use-customdatastringformat-for-text-input
branch
from
3ece70e
to
464e85e
Compare
MrJul
requested changes
Nov 12, 2024
punker76
force-pushed
the
fixes/17291-use-customdatastringformat-for-text-input
branch
from
464e85e
to
ef813e2
Compare
|
You can test this PR using the following package version. |
|
You can test this PR using the following package version. |
maxkatz6
added
bug
backport-candidate-11.2.x
maxkatz6
approved these changes
Nov 14, 2024
maxkatz6
added
backported-11.2.x
and removed
backport-candidate-11.2.x
punker76
deleted the
fixes/17291-use-customdatastringformat-for-text-input
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
This PR looks for possible existing CustomDateFormatString and use it for parsing text input. Also the watermark will use now the CustomDateFormatString.
What is the current behavior?
The CustomDateFormatString is ignored and will also throw exceptions. See #17291
What is the updated/expected behavior with this PR?
Now exception is throen and the text is parsed to the excpected DateTime.
How was the solution implemented (if it's not obvious)?
Checklist
Breaking changes
Obsoletions / Deprecations
Fixed issues
Fixes #17291