Fix FontCollection glyph typeface caching #17519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… find the nearest match
Gillibald
added
the
backport-candidate-11.2.x
|
You can test this PR using the following package version. |
Gillibald
changed the title
Gillibald
changed the title
|
You can test this PR using the following package version. |
|
You can test this PR using the following package version. |
maxkatz6
approved these changes
Nov 18, 2024
maxkatz6
pushed a commit
that referenced
this pull request
Nov 26, 2024
* Make sure we always cache the created glyph typeface before we try to find the nearest match * Cleanup usings * Add failing test * Cache the matched glyph typeface for EmbeddedFontCollection
maxkatz6
added
backported-11.2.x
and removed
backport-candidate-11.2.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
This PR ensures the current IFontCollection implementations properly cache glyph typeface when they create a synthetic typeface.
This also changes the SystemFontCollection so created glyph typefaces are added to the cache before the nearest match is attempted to be found.
What is the current behavior?
What is the updated/expected behavior with this PR?
How was the solution implemented (if it's not obvious)?
Checklist
Breaking changes
Obsoletions / Deprecations
Fixed issues