Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix npm install for parallel builds #17532

Merged
merged 1 commit into from
Nov 18, 2024

Conversation

MrJul
Copy link
Member

@MrJul MrJul commented Nov 17, 2024

What does the pull request do?

After #17452, we now have multiple target frameworks for the Avalonia.Browser project.

Building these in parallel often causes npm install or npm run build to run twice at the same time, causing various errors.
Since these commands don't depend on a specific TFM, they're now executed before the inner framework-specific builds.

@MrJul MrJul added bug area-infrastructure Issues related to CI/tooling infrastructur labels Nov 17, 2024
@avaloniaui-bot
Copy link

You can test this PR using the following package version. 11.3.999-cibuild0053374-alpha. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

@maxkatz6 maxkatz6 merged commit 973791f into AvaloniaUI:master Nov 18, 2024
11 checks passed
@maxkatz6 maxkatz6 added the backport-candidate-11.2.x Consider this PR for backporting to 11.2 branch label Nov 18, 2024
maxkatz6 pushed a commit that referenced this pull request Nov 26, 2024
@maxkatz6 maxkatz6 added backported-11.2.x and removed backport-candidate-11.2.x Consider this PR for backporting to 11.2 branch labels Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-infrastructure Issues related to CI/tooling infrastructur backported-11.2.x bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants