Fix SelectedItemsChanged event arguments in SelectingItemsControl #1913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Idk if this should be added to the breaking changes. Someone might've been relying on the wrong parameters. |
|
I haven't found any issues referencing this bug, so it's unlikely anyone quietly assumed this will remain broken forever. I'd say it's more likely no one used this feature until now. |
|
Wow thats a good spot! @jmacato should we get this into 0.7? |
|
@danwalmsley I do think this is a critical bug fix that needs to be included with the release |
Closed
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corrects the event arguments for replacing a selected item in SelectingItemsControl.
The arguments for the SelectedItemsChanged event are inverted.
Sets the arguments as expected.
Checklist: