Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GlyphRun support #3202

Merged
merged 2 commits into from
Dec 6, 2019
Merged

GlyphRun support #3202

merged 2 commits into from
Dec 6, 2019

Conversation

Gillibald
Copy link
Contributor

@Gillibald Gillibald commented Nov 3, 2019

What does the pull request do?

This is the second part of a series of PRs that lead to a new text rendering environment. This adds GlyphRun support. GlyphRun is a low level components that lets you work with glyphs etc.

What is the current behavior?

Not supported.

What is the updated/expected behavior with this PR?

It is possible to render runs of glyphs on the screen.

How was the solution implemented (if it's not obvious)?

Checklist

Depends on #3234

Part of #132

@Gillibald Gillibald changed the title GlyphRun support [WIP] GlyphRun support Nov 3, 2019
samples/RenderDemo/RenderDemo.csproj Outdated Show resolved Hide resolved
src/Avalonia.Visuals/Avalonia.Visuals.csproj Outdated Show resolved Hide resolved
@Gillibald Gillibald changed the title [WIP] GlyphRun support GlyphRun support Nov 5, 2019
@dep dep bot added the dependent label Nov 16, 2019
@Gillibald
Copy link
Contributor Author

Hmm. Calling InvalidateVisual on the GlyphRun page isn't redrawing anything. Have to find out what is going wrong.

src/Avalonia.Visuals/Media/GlyphRun.cs Outdated Show resolved Hide resolved
src/Avalonia.Visuals/Media/GlyphRun.cs Outdated Show resolved Hide resolved
src/Avalonia.Visuals/Media/GlyphRun.cs Outdated Show resolved Hide resolved
src/Avalonia.Visuals/Media/GlyphRun.cs Outdated Show resolved Hide resolved
src/Avalonia.Visuals/Utility/ReadOnlySlice.cs Show resolved Hide resolved
Copy link
Member

@grokys grokys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again, not that qualified to review this, but from what I understand it looks great! Just one tiny nit and one question.

@Gillibald Gillibald merged commit 70e6f06 into AvaloniaUI:master Dec 6, 2019
@Gillibald Gillibald deleted the feature/GlyphRun branch December 6, 2019 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants