-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GlyphRun support #3202
Merged
Merged
GlyphRun support #3202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarchingCube
reviewed
Nov 3, 2019
MarchingCube
reviewed
Nov 4, 2019
Gillibald
commented
Nov 4, 2019
Hmm. Calling InvalidateVisual on the GlyphRun page isn't redrawing anything. Have to find out what is going wrong. |
Gillibald
commented
Nov 21, 2019
Gillibald
force-pushed
the
feature/GlyphRun
branch
from
December 4, 2019 17:22
080084f
to
c2f30e7
Compare
grokys
approved these changes
Dec 6, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Again, not that qualified to review this, but from what I understand it looks great! Just one tiny nit and one question.
Gillibald
force-pushed
the
feature/GlyphRun
branch
from
December 6, 2019 20:13
475743c
to
ab5e062
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
This is the second part of a series of PRs that lead to a new text rendering environment. This adds GlyphRun support. GlyphRun is a low level components that lets you work with glyphs etc.
What is the current behavior?
Not supported.
What is the updated/expected behavior with this PR?
It is possible to render runs of glyphs on the screen.
How was the solution implemented (if it's not obvious)?
Checklist
Depends on #3234
Part of #132