Cache delegates used for reacting to logical and visual children changes #3296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
Another case of C# syntax sugar causing extra allocations. Found this when checking #3292 and wondering what do we actually allocate there.
What is the current behavior?
We allocate up to 128 bytes of delegates per
Control. 64 bytes inVisualis always allocated, 64 bytes inStyledElementwhen we access logical children for the first time (quite common as well, but not always).What is the updated/expected behavior with this PR?
Both delegates are cached by the compiler automatically.
How was the solution implemented (if it's not obvious)?
Checklist