Remove generic methods from ILogSink. #8079
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Part of the push to remove generic virtual methods from Avalonia for performance reasons. Generic methods were added to this interface in #3055 to prevent boxing before we added `Logger.TryGet` (#4135). Given that since we added `Logger.TryGet`, only enabled logging levels will result in a call to the logger, we can move back to using `params object[]` and boxing; removing the generic interface methods.
|
You can test this PR using the following package version. |
|
You can test this PR using the following package version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
Part of the push to remove generic virtual methods from Avalonia for performance reasons. Although this PR shouldn't affect performance, it will probably improve AOT compilation times slightly.
Generic methods were added to this interface in #3055 to prevent boxing before we added
Logger.TryGet(#4135).Given that since we added
Logger.TryGet, only enabled logging levels will result in a call to the logger, we can move back to usingparams object[]and boxing; removing the generic interface methods.Ran a few benchmarks and as expected this has no affect on performance in release mode as logging should not be enabled there.
Breaking changes
ILogSinkhas changed.