-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix more macos window issues and add more integration tests. #8405
Commits on Jun 24, 2022
-
Don't return FrameSize until window is shown.
Since #8629, the content size isn't set until the window is shown, so we can't know the frame size.
Configuration menu - View commit details
-
Copy full SHA for 355ba94 - Browse repository at this point
Copy the full SHA 355ba94View commit details -
A non-client click was being received after the click to minimize the window, which caused a call to `_parent->BringToFront();`, meaning the window got immediately restored. Ignore clicks when the window is minimized. Fixes #8335
Configuration menu - View commit details
-
Copy full SHA for 20ddbad - Browse repository at this point
Copy the full SHA 20ddbadView commit details -
Configuration menu - View commit details
-
Copy full SHA for 328aef8 - Browse repository at this point
Copy the full SHA 328aef8View commit details
Commits on Jun 27, 2022
-
Set actualWindowState earlier.
Previously, `_actualWindowState` was being set after the window state had finished changing, but `ExitFullScreenMode` calls `UpdateStyle` which expects `_actualWindowState` to be up-to-date, meaning that previously we ended up with an invalid size when exiting full screen mode programatically.
Configuration menu - View commit details
-
Copy full SHA for dfa0c44 - Browse repository at this point
Copy the full SHA dfa0c44View commit details -
`Window.Position` isn't an Avalonia property so doesn't auto-update, we need to listen for `PositionChanged`.
Configuration menu - View commit details
-
Copy full SHA for 519e850 - Browse repository at this point
Copy the full SHA 519e850View commit details -
- Add a retry to `GetWindowInfo` - Owned windows can't go fullscreen on macOS.
Configuration menu - View commit details
-
Copy full SHA for 2677107 - Browse repository at this point
Copy the full SHA 2677107View commit details -
Revert "Fix window minimization."
This reverts commit 20ddbad. It didn't work with owned windows, there's something else going on here.
Configuration menu - View commit details
-
Copy full SHA for 4b08e65 - Browse repository at this point
Copy the full SHA 4b08e65View commit details -
Fix window minimization attempt 2.
The previous solution didn't work for owned windows. Hopefully this fixes the problem at its root: that `BringToFront` activates a window even if it's miniaturized.
Configuration menu - View commit details
-
Copy full SHA for 2822f5b - Browse repository at this point
Copy the full SHA 2822f5bView commit details -
Added a retry to macOS window tests.
MacOS sometimes seems to need a bit of time to get itself back in order after switching out of fullscreen.
Configuration menu - View commit details
-
Copy full SHA for cd04964 - Browse repository at this point
Copy the full SHA cd04964View commit details -
Use manual window startup location in macOS tests.
Seems to cause less flaky tests; `mainWindow.Click()` clicks the main window in the middle, where the secondary window is shown, so don't go out of our way to put the secondary window in front of where we're clicking.
Configuration menu - View commit details
-
Copy full SHA for 19c5510 - Browse repository at this point
Copy the full SHA 19c5510View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4f84950 - Browse repository at this point
Copy the full SHA 4f84950View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7156339 - Browse repository at this point
Copy the full SHA 7156339View commit details -
Configuration menu - View commit details
-
Copy full SHA for 91fc133 - Browse repository at this point
Copy the full SHA 91fc133View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4e63f19 - Browse repository at this point
Copy the full SHA 4e63f19View commit details
Commits on Jun 28, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 19ca0ff - Browse repository at this point
Copy the full SHA 19ca0ffView commit details -
Configuration menu - View commit details
-
Copy full SHA for cebd5b1 - Browse repository at this point
Copy the full SHA cebd5b1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 15c26b9 - Browse repository at this point
Copy the full SHA 15c26b9View commit details