Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix more macos window issues and add more integration tests. #8405

Merged
merged 17 commits into from
Jun 28, 2022

Commits on Jun 24, 2022

  1. Don't return FrameSize until window is shown.

    Since #8629, the content size isn't set until the window is shown, so we can't know the frame size.
    grokys committed Jun 24, 2022
    Configuration menu
    Copy the full SHA
    355ba94 View commit details
    Browse the repository at this point in the history
  2. Fix window minimization.

    A non-client click was being received after the click to minimize the window, which caused a call to `_parent->BringToFront();`, meaning the window got immediately restored. Ignore clicks when the window is minimized.
    
    Fixes #8335
    grokys committed Jun 24, 2022
    Configuration menu
    Copy the full SHA
    20ddbad View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    328aef8 View commit details
    Browse the repository at this point in the history

Commits on Jun 27, 2022

  1. Set actualWindowState earlier.

    Previously, `_actualWindowState` was being set after the window state had finished changing, but `ExitFullScreenMode` calls `UpdateStyle` which expects `_actualWindowState` to be up-to-date, meaning that previously we ended up with an invalid size when exiting full screen mode programatically.
    grokys committed Jun 27, 2022
    Configuration menu
    Copy the full SHA
    dfa0c44 View commit details
    Browse the repository at this point in the history
  2. Correctly update position.

    `Window.Position` isn't an Avalonia property so doesn't auto-update, we need to listen for `PositionChanged`.
    grokys committed Jun 27, 2022
    Configuration menu
    Copy the full SHA
    519e850 View commit details
    Browse the repository at this point in the history
  3. Tweak tests.

    - Add a retry to `GetWindowInfo`
    - Owned windows can't go fullscreen on macOS.
    grokys committed Jun 27, 2022
    Configuration menu
    Copy the full SHA
    2677107 View commit details
    Browse the repository at this point in the history
  4. Revert "Fix window minimization."

    This reverts commit 20ddbad.
    
    It didn't work with owned windows, there's something else going on here.
    grokys committed Jun 27, 2022
    Configuration menu
    Copy the full SHA
    4b08e65 View commit details
    Browse the repository at this point in the history
  5. Fix window minimization attempt 2.

    The previous solution didn't work for owned windows. Hopefully this fixes the problem at its root: that `BringToFront` activates a window even if it's miniaturized.
    grokys committed Jun 27, 2022
    Configuration menu
    Copy the full SHA
    2822f5b View commit details
    Browse the repository at this point in the history
  6. Added a retry to macOS window tests.

    MacOS sometimes seems to need a bit of time to get itself back in order after switching out of fullscreen.
    grokys committed Jun 27, 2022
    Configuration menu
    Copy the full SHA
    cd04964 View commit details
    Browse the repository at this point in the history
  7. Use manual window startup location in macOS tests.

    Seems to cause less flaky tests; `mainWindow.Click()` clicks the main window in the middle, where the secondary window is shown, so don't go out of our way to put the secondary window in front of where we're clicking.
    grokys committed Jun 27, 2022
    Configuration menu
    Copy the full SHA
    19c5510 View commit details
    Browse the repository at this point in the history
  8. Added tests for #8335.

    grokys committed Jun 27, 2022
    Configuration menu
    Copy the full SHA
    4f84950 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    7156339 View commit details
    Browse the repository at this point in the history
  10. Sigh, winappdriver.

    grokys committed Jun 27, 2022
    Configuration menu
    Copy the full SHA
    91fc133 View commit details
    Browse the repository at this point in the history
  11. Account for scaling.

    grokys committed Jun 27, 2022
    Configuration menu
    Copy the full SHA
    4e63f19 View commit details
    Browse the repository at this point in the history

Commits on Jun 28, 2022

  1. Configuration menu
    Copy the full SHA
    19ca0ff View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    cebd5b1 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    15c26b9 View commit details
    Browse the repository at this point in the history