Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix allow scroll below document #254

Merged
merged 4 commits into from
Sep 19, 2022
Merged

Fix allow scroll below document #254

merged 4 commits into from
Sep 19, 2022

Commits on Sep 19, 2022

  1. Synchronize upstream code 

    Remove the _documentSize var and directly use the _scrollExtent, like the upstream project. Cleanup commented code.
    @danipen
    danipen committed Sep 19, 2022
    Configuration menu
    Copy the full SHA
    6bc7bf4 View commit details
    Browse the repository at this point in the history

  2. Fix AllowScrollBelowDocument 

    This commit fixes AllowScrollBelowDocument option. The events chain in the ScrollViewer prevented AvaloniaEdit to reserve more space because when the scrollbar reached the max viewport no new events were send, so the code did not work as WPF.

Instead, I changed the implementation to behave as Visual Studio / Visual Studio Code / Sublime. They basically adds an extra Bounds.Height - minimum distance (tipically one line) when the option is enabled.
    @danipen
    danipen committed Sep 19, 2022
    Configuration menu
    Copy the full SHA
    ce786ab View commit details
    Browse the repository at this point in the history

  3. Subscribe FontFamily and FontSize property changes in the TextEditor 

    and set them to the TextView to cause it to call InvalidateDefaultTextMetrics()
    @danipen
    danipen committed Sep 19, 2022
    Configuration menu
    Copy the full SHA
    c996c3b View commit details
    Browse the repository at this point in the history

  4. Do not use margins when bringing the caret into the view to avoid scr… 

    …oll jumps

just align the line top to the view, as other editor do (VS, VSCode, Sublime)
    @danipen
    danipen committed Sep 19, 2022
    Configuration menu
    Copy the full SHA
    f59d3ef View commit details
    Browse the repository at this point in the history