Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix triple click causes NRE #277

Merged
merged 3 commits into from
Oct 25, 2022
Merged

Fix triple click causes NRE #277

merged 3 commits into from
Oct 25, 2022

Conversation

danipen
Copy link
Collaborator

@danipen danipen commented Oct 18, 2022

Taking a look at the upstream project, it seems that the code doesn't belong there.

Additionally, protect the code to avoid call GetTextLineByVisualYPosition when the VisualLines have not been set yet.

Fixes #276

Taking a look to the upstream project, it seems that code doesn't belong there. I fixes #276
@danipen danipen requested review from Gillibald and removed request for miryamGSM October 18, 2022 15:47
@danipen danipen merged commit 8719db6 into master Oct 25, 2022
@Takoooooo Takoooooo deleted the fix-276 branch November 30, 2022 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Triple click causes NRE
1 participant