Change ICompletionData.Image from Bitmap to IImage #341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I propose changing
ICompletionData.ImagefromBitmaptoIImage. HavingBitmapin the interface is unnecessarily restrictive. Changing the type toIImageallows other types of image sources. For example:CroppedBitmap,DrawingImageIn my case, I have an icon font that has a custom
IImageimplementation.⚠ Note that this is a breaking change! Any application implementing
IComplectionData(like AvaloniaEdit.Demo) will have to be updated. However, I think that this change is worthwhile and should be made before releasing 11.0.0.