Fix: Column ruler behind current line highlight #343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgarstenauer
force-pushed
the
fix-columnruler-behind-currentlinehighlight
branch
from
9479472
to
3f42e80
Compare
mgarstenauer
force-pushed
the
fix-columnruler-behind-currentlinehighlight
branch
from
3f42e80
to
f1c800c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
The vertical column ruler is rendered behind the current line highlight.
Fix:
I suggest changing
CurrentLineHighlightRenderer.LayertoKnownLayer.Background. This way, the vertical column ruler and other highlights (such as search result markers) can be rendered on top.In
TextViewtheColumnRulerRendererneeds to be registered after theCurrentLineHighlightRenderer.Also fixed a typo in the existing code.