Allow customisation of the keys that trigger insertation of a completion #358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dotnet-policy-service agree |
danipen
requested changes
Jul 19, 2023
|
Done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some people might not want to insert code completions using the enter key because they want to be able to create line breaks even when a completion window shows up. For example they might only want to insert completions using the tab key.
This PR adds a
Key[]calledCompletionAcceptKeysto theCompletionListClass. Now, when a keypress is handled by the completion list, it will check if the pressed key is is present in the CompletionAcceptKeys array instead of deciding based on the hard coded switch statement.By default, this array will contain the Enter key and the tab key, so the behavior is unchanged.