Migrate to Avalonia 11.0.4 #371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
since they're not passing anymore since we migrated to the headless platform.
Gillibald
approved these changes
Sep 6, 2023
|
@Takoooooo are you planning to generate nugets? |
|
@danipen I guess we agreed with team members to not migrate NuGet's to minor 11.0.x versions to not force people to update their apps to minor versions |
|
I think we need to revert this PR unless 11.0.4 includes some very important fixes for AvaloniaEdit |
|
Ok. But note that without these changes the build is broken. Cc @maxkatz6 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No changes. Just use the new version.
@maxkatz6 please note that the
WeakReferenceTests.cswere not migrated to the headless platform. I changed to migrate them, but they are not passing anymore in the headless platform. Please, take a look if you want to re-enable them.