Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix exe other-modules containing dots #22

Merged
merged 2 commits into from
Oct 15, 2020
Merged

Fix exe other-modules containing dots #22

merged 2 commits into from
Oct 15, 2020

Conversation

jneira
Copy link
Collaborator

@jneira jneira commented Oct 14, 2020

@jneira jneira requested a review from Avi-D-coder October 14, 2020 20:29
fendor
fendor approved these changes Oct 14, 2020
View reviewed changes
Copy link
Collaborator

@fendor fendor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jneira jneira mentioned this pull request Oct 15, 2020
Closed
@jneira
Copy link
Collaborator Author

jneira commented Oct 15, 2020

I've checked a hls version with this patch in windows and it works, so merging

@jneira jneira merged commit f971186 into Avi-D-coder:master Oct 15, 2020
@jneira
Copy link
Collaborator Author

jneira commented Oct 15, 2020

@Avi-D-coder could we publish a hackage version with the fix?

@Avi-D-coder
Copy link
Owner

Will do

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fendor fendor fendor approved these changes

@Avi-D-coder Avi-D-coder Avi-D-coder approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Executables with other-modules end up with incorrect paths
3 participants
@jneira @Avi-D-coder @fendor