Rename "relayer", "user gateway" and "relaying gateway" #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gnarea
added a commit
to relaycorp/awala-gateway-internet
that referenced
this pull request
Feb 15, 2020
gnarea
added a commit
to relaycorp/relaynet-core-js
that referenced
this pull request
Feb 15, 2020
gnarea
added a commit
to relaycorp/relaynet-core-js
that referenced
this pull request
Feb 15, 2020
gnarea
added a commit
to relaycorp/awala-gateway-internet
that referenced
this pull request
Feb 20, 2020
* Install dependencies * Use Node 12 in functional tests * Transpile TS in Docker container instead of host So we can use Node 12 * Fix syntax error in Circle CI config * Fix typo * Fix permissions after transpiling TS in functional tests * Fix args passed to `chown` * Implement stub for server * Implement server * Remove stub client used for testing * Refactor * Rename NATS subject for parcels received via PDC * Implement deliverCargo() method * Rename "relayer", "user gateway" and "relaying gateway" AwalaApp/specs#39 * Fix conding convention violation * Complete service implementation integration * Upgrade NATS streaming server * Implement function to publish messages with NATS streaming * Support streaming arrays * Prevent NATS publisher from being reused * Move NATS publisher to new class * Make NATS Streaming connection async to simplify code * Introduce method to send single NATS message * Refactor tests ahead of implementation * Migrate PoHTTP interface to NATS Streaming * Upgrade Jest and related deps * Convert stream-based implementation to iterable-based * Fix processing of invalid cargoes * Make NATS streaming publisher yield ids of published msgs * Integrate NATS Streaming in deliverCargo method * Remove plain NATS integration * Integrate NATS Streaming in gRPC service factory
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #20.
"relayer" -> "courier"
Because "courier" is a good analogy and needs little explanation.
"user gateway" -> "private gateway"
The word "user" in this context was misleading at best and wrong at worst:
"relaying gateway" -> "public gateway"
For consistency with the change above. Also, "relaying" was superfluous -- All nodes in Relaynet relay stuff.