Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

np.float is deprecated #789

Merged
merged 2 commits into from
Jan 14, 2024
Merged

np.float is deprecated #789

merged 2 commits into from
Jan 14, 2024

Conversation

dachengx
Copy link
Collaborator

@dachengx dachengx commented Jan 14, 2024

What is the problem / what does the code in this PR do

Using the aliases of builtin types like np.int is deprecated

reference: https://numpy.org/devdocs/release/1.20.0-notes.html#deprecations

In principle the auto tests in XENONnT/base_environment#1483 will not pass, but the line changed in this PR was never checked:

image

Can you briefly describe how it works?

Can you give a minimal working example (or illustrate with a figure)?

Please include the following if applicable:

  • Update the docstring(s)
  • Update the documentation
  • Tests to check the (new) code is working as desired.
  • Does it solve one of the open issues on github?

Please make sure that all automated tests have passed before asking for a review (you can save the PR as a draft otherwise).

Copy link

Coverage Status

coverage: 91.352%. remained the same
when pulling 8d33de1 on deprecated_float
into 7396d79 on master.

@dachengx dachengx marked this pull request as ready for review January 14, 2024 06:30
@coveralls
Copy link

Coverage Status

coverage: 91.062% (-0.3%) from 91.352%
when pulling 8d33de1 on deprecated_float
into 7396d79 on master.

@dachengx dachengx merged commit f1471d0 into master Jan 14, 2024
11 checks passed
@WenzDaniel
Copy link
Collaborator

Thanks Dacheng

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants