Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not call get_components in is_stored #813

Merged
merged 1 commit into from
Apr 4, 2024

Conversation

dachengx
Copy link
Collaborator

@dachengx dachengx commented Apr 4, 2024

What is the problem / what does the code in this PR do

Further simplify #796. Because get_components will call the initialization of FileSaver, which will try to make and delete _temp folders.

See slack thread.

Can you briefly describe how it works?

Can you give a minimal working example (or illustrate with a figure)?

Please include the following if applicable:

  • Update the docstring(s)
  • Update the documentation
  • Tests to check the (new) code is working as desired.
  • Does it solve one of the open issues on github?

Please make sure that all automated tests have passed before asking for a review (you can save the PR as a draft otherwise).

@dachengx dachengx requested a review from cfuselli April 4, 2024 13:40
@dachengx dachengx marked this pull request as ready for review April 4, 2024 13:46
@dachengx dachengx merged commit 24abd04 into master Apr 4, 2024
9 checks passed
@dachengx dachengx deleted the no_default_detail_is_stored branch April 4, 2024 14:08
@coveralls
Copy link

Coverage Status

coverage: 91.475% (-0.08%) from 91.557%
when pulling 6d4223d on no_default_detail_is_stored
into 243eb2b on master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants