Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pick out selection applying function #826

Merged
merged 2 commits into from
Apr 24, 2024
Merged

Pick out selection applying function #826

merged 2 commits into from
Apr 24, 2024

Conversation

dachengx
Copy link
Collaborator

What is the problem / what does the code in this PR do

Pick out the lines inside strax.utils.apply_selection where the selection is applied to be a stand-alone function parse_selection for other uses. Nothing changed functionally.

Can you briefly describe how it works?

Can you give a minimal working example (or illustrate with a figure)?

Please include the following if applicable:

  • Update the docstring(s)
  • Update the documentation
  • Tests to check the (new) code is working as desired.
  • Does it solve one of the open issues on github?

Please make sure that all automated tests have passed before asking for a review (you can save the PR as a draft otherwise).

@dachengx dachengx requested a review from yuema137 April 24, 2024 17:45
@coveralls
Copy link

coveralls commented Apr 24, 2024

Coverage Status

coverage: 91.507% (+0.005%) from 91.502%
when pulling 5418206 on apply_selection
into 67a7831 on master.

@dachengx dachengx marked this pull request as ready for review April 24, 2024 17:57
@dachengx dachengx merged commit b9f4641 into master Apr 24, 2024
9 checks passed
@dachengx dachengx deleted the apply_selection branch April 24, 2024 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants