Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent start being negative #828

Merged
merged 1 commit into from
Apr 25, 2024
Merged

Prevent start being negative #828

merged 1 commit into from
Apr 25, 2024

Conversation

dachengx
Copy link
Collaborator

What is the problem / what does the code in this PR do
Negative start is not compatible with

self.sent_until = 0
and
prev_end = 0

Can you briefly describe how it works?

Can you give a minimal working example (or illustrate with a figure)?

Please include the following if applicable:

  • Update the docstring(s)
  • Update the documentation
  • Tests to check the (new) code is working as desired.
  • Does it solve one of the open issues on github?

Please make sure that all automated tests have passed before asking for a review (you can save the PR as a draft otherwise).

@dachengx dachengx requested a review from yuema137 April 25, 2024 20:50
@coveralls
Copy link

Coverage Status

coverage: 91.196% (+0.002%) from 91.194%
when pulling ba97ac2 on no_negative_start
into 9454279 on master.

2 similar comments
@coveralls
Copy link

Coverage Status

coverage: 91.196% (+0.002%) from 91.194%
when pulling ba97ac2 on no_negative_start
into 9454279 on master.

@coveralls
Copy link

Coverage Status

coverage: 91.196% (+0.002%) from 91.194%
when pulling ba97ac2 on no_negative_start
into 9454279 on master.

@dachengx dachengx marked this pull request as ready for review April 25, 2024 21:06
@dachengx dachengx changed the title Prevent start to be negative Prevent start being negative Apr 25, 2024
@dachengx dachengx merged commit 7da9a2a into master Apr 25, 2024
9 checks passed
@dachengx dachengx deleted the no_negative_start branch April 25, 2024 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants