Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow _chunk_number to be list or tuple #856

Merged
merged 1 commit into from
Jul 18, 2024
Merged

Conversation

dachengx
Copy link
Collaborator

@dachengx dachengx commented Jul 12, 2024

What is the problem / what does the code in this PR do

This is helpful when you just want to process several chunks for testing.

_chunk_number will be propagated from get_iter:

_chunk_number=None,

Can you briefly describe how it works?

Can you give a minimal working example (or illustrate with a figure)?

Please include the following if applicable:

  • Update the docstring(s)
  • Update the documentation
  • Tests to check the (new) code is working as desired.
  • Does it solve one of the open issues on github?

Please make sure that all automated tests have passed before asking for a review (you can save the PR as a draft otherwise).

@coveralls
Copy link

Coverage Status

coverage: 90.429% (-0.08%) from 90.507%
when pulling d264b25 on chunk_number_list
into bb23240 on master.

@dachengx dachengx requested a review from yuema137 July 17, 2024 17:07
@dachengx dachengx marked this pull request as ready for review July 17, 2024 17:07
Copy link
Collaborator

@yuema137 yuema137 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's straightforward and looks good. Thanks.

@dachengx dachengx merged commit 48eb230 into master Jul 18, 2024
9 checks passed
@dachengx dachengx deleted the chunk_number_list branch July 18, 2024 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants