Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter out duplicated targets in function get_iter #860

Merged
merged 1 commit into from
Aug 1, 2024

Conversation

dachengx
Copy link
Collaborator

@dachengx dachengx commented Aug 1, 2024

What is the problem / what does the code in this PR do

Fix #846

The reason this can work is explained here: #859 (comment)

Can you briefly describe how it works?

Remove duplicated targets when get_iter.

Can you give a minimal working example (or illustrate with a figure)?

Please include the following if applicable:

  • Update the docstring(s)
  • Update the documentation
  • Tests to check the (new) code is working as desired.
  • Does it solve one of the open issues on github?

Please make sure that all automated tests have passed before asking for a review (you can save the PR as a draft otherwise).

@coveralls
Copy link

Coverage Status

coverage: 90.43% (+0.001%) from 90.429%
when pulling 187970f on unique_targets
into 2218e78 on master.

@dachengx dachengx marked this pull request as ready for review August 1, 2024 14:23
@dachengx dachengx merged commit 529886d into master Aug 1, 2024
9 checks passed
@dachengx dachengx deleted the unique_targets branch August 1, 2024 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Zero length array returned when targets duplicated
2 participants