Save subruns information of hyperrun #869
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the problem / what does the code in this PR do
Hyperrun "process" subruns into hyperrun. This is different from the superrun workflow, where the subruns are only concatenated in Rechunker. But hyperrun concatenates the subruns in
Plugin._fetch_chunk
and split subruns inPlugin.iter
. Previously the concatenation does not collect the information from different subrus so the metadata of subruns is not stored in metadata of hyperrun.Can you briefly describe how it works?
This PR changes:
superrun
toChunk
to store the subruns information:"start"
and"end"
._merge_superrun_in_chunk
,_merge_runs_in_chunk
, and_continuity_check
to handle the metadata of subruns in attributesuperrun
, such as merge different subruns and split metadata while splitting data.superrun
to chunk inPlugin.do_compute
. If there are multiple subruns inChunk.superrun
, we must assign theChunk.subruns
to theChunk.superrun
because hyperrun's subruns information is only handled here.Can you give a minimal working example (or illustrate with a figure)?
Please look at the
test_hyperrun_chunk_properties
test function intests/test_hyperruns.py
.Please include the following if applicable:
Please make sure that all automated tests have passed before asking for a review (you can save the PR as a draft otherwise).