Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prohibit chunk_number for LoopPlugin and OverlapWindowPlugin #877

Merged
merged 2 commits into from
Aug 24, 2024

Conversation

dachengx
Copy link
Collaborator

What is the problem / what does the code in this PR do

The reason for this PR is described at #875.

Close #874
Close #875

Can you briefly describe how it works?

Can you give a minimal working example (or illustrate with a figure)?

Please include the following if applicable:

  • Update the docstring(s)
  • Update the documentation
  • Tests to check the (new) code is working as desired.
  • Does it solve one of the open issues on github?

Please make sure that all automated tests have passed before asking for a review (you can save the PR as a draft otherwise).

@dachengx dachengx marked this pull request as ready for review August 24, 2024 17:00
@coveralls
Copy link

coveralls commented Aug 24, 2024

Coverage Status

coverage: 91.118% (+0.7%) from 90.465%
when pulling 38f7eee on more_check_chunk_number
into c83050b on master.

@dachengx dachengx merged commit 41a21bc into master Aug 24, 2024
7 of 8 checks passed
@dachengx dachengx deleted the more_check_chunk_number branch August 24, 2024 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants