Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only save combined data_type in only-combining mode #878

Merged
merged 4 commits into from
Aug 25, 2024

Conversation

dachengx
Copy link
Collaborator

What is the problem / what does the code in this PR do

Close #876.

The reason for this PR is in the issue description.

Can you briefly describe how it works?

If _combining_subruns is True, only save the targeted data_type.

Can you give a minimal working example (or illustrate with a figure)?

Please include the following if applicable:

  • Update the docstring(s)
  • Update the documentation
  • Tests to check the (new) code is working as desired.
  • Does it solve one of the open issues on github?

Please make sure that all automated tests have passed before asking for a review (you can save the PR as a draft otherwise).

@dachengx dachengx marked this pull request as ready for review August 24, 2024 19:15
@coveralls
Copy link

coveralls commented Aug 24, 2024

Coverage Status

coverage: 91.236% (+0.1%) from 91.118%
when pulling 84e7697 on savers_combining_subruns
into 41a21bc on master.

@dachengx dachengx merged commit cb7e232 into master Aug 25, 2024
8 checks passed
@dachengx dachengx deleted the savers_combining_subruns branch August 25, 2024 04:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extra savers in only-combining mode for superrun
2 participants