Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No run_id dependent plugin version #880

Merged
merged 9 commits into from
Aug 26, 2024
Merged

Conversation

dachengx
Copy link
Collaborator

@dachengx dachengx commented Aug 25, 2024

What is the problem / what does the code in this PR do

Because time dependency is handled by time-dependent corrections. This PR also set Plugin.version as a classmethod.

Close #862
Close #688

Can you briefly describe how it works?

Can you give a minimal working example (or illustrate with a figure)?

Please include the following if applicable:

  • Update the docstring(s)
  • Update the documentation
  • Tests to check the (new) code is working as desired.
  • Does it solve one of the open issues on github?

Please make sure that all automated tests have passed before asking for a review (you can save the PR as a draft otherwise).

@dachengx dachengx marked this pull request as ready for review August 25, 2024 05:47
@dachengx
Copy link
Collaborator Author

Might be related to #688

@coveralls
Copy link

coveralls commented Aug 25, 2024

Coverage Status

coverage: 91.285% (+0.07%) from 91.219%
when pulling 12c1880 on run_id_independent_version
into e88feba on master.

@dachengx dachengx merged commit 1e42cda into master Aug 26, 2024
8 checks passed
@dachengx dachengx deleted the run_id_independent_version branch August 26, 2024 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

We do not need run_id dependent plugin version Plugin.__version__ and Plugin.version are ambigous
2 participants